refactor cli #258
Merged
refactor cli #258
+436
−463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent Rancourt <[email protected]>
✅ Deploy Preview for docs-kargo-render-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
==========================================
- Coverage 20.90% 20.81% -0.09%
==========================================
Files 26 22 -4
Lines 1818 1797 -21
==========================================
- Hits 380 374 -6
+ Misses 1404 1390 -14
+ Partials 34 33 -1 ☔ View full report in Codecov by Sentry. |
hiddeco
reviewed
Mar 20, 2024
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
krancour
force-pushed
the
krancour/cli-cleanup
branch
from
8a62aa3 to
4cc8212
Compare
hiddeco
approved these changes
Mar 20, 2024
|
(Linter does not agree though, but that should be addressable). |
Signed-off-by: Kent Rancourt <[email protected]>
Whoops. Something snuck in from another branch I was working on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #229, which is in-turn an enabled for akuity/kargo#1330, I intend to add at least a couple new flags.
I decided I'd like to get CLI refactoring similar to what was done in Kargo proper out of the way first in order to have a nice, clean starting point.
Edit: This also undoes the awkward bit where the main program looks at argo 0 to decide on running the CLI or the action. The action is now just a hidden command of the CLI.